Skip to content

Commit

Permalink
remove superfluous attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
DaveSkender committed Nov 3, 2024
1 parent aa4c195 commit 25c6881
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
8 changes: 2 additions & 6 deletions src/_common/Quotes/Quote.Converters.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using System.ComponentModel;

namespace Skender.Stock.Indicators;

// QUOTE UTILITIES (CONVERTERS)
Expand All @@ -8,8 +6,7 @@ public static partial class Quotes
{
/* LISTS */

// convert TQuote type list to built-in Quote type list
[Category("Public API only")]
// convert TQuote type list to built-in Quote type list (public API only)
public static IReadOnlyList<Quote> ToQuoteList<TQuote>(
this IReadOnlyList<TQuote> quotes)
where TQuote : IQuote
Expand All @@ -30,8 +27,7 @@ internal static List<QuoteD> ToQuoteDList<TQuote>(

/* TYPES */

// convert any IQuote type to native Quote type
[Category("Public API only")]
// convert any IQuote type to native Quote type (public API only)
public static Quote ToQuote<TQuote>(this TQuote quote)
where TQuote : IQuote

Expand Down
7 changes: 2 additions & 5 deletions src/s-z/Sma/Sma.Utilities.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using System.ComponentModel;
using System.Diagnostics.CodeAnalysis;
using System.Numerics;

Expand All @@ -24,8 +23,7 @@ public static partial class Sma
/// if incalculable <see langword="double.NaN"/>
/// values are in range.
/// </returns>
[Category("Public API only")]
public static double? Average<T>(
public static double? Average<T>( // public API only
this IReadOnlyList<T> values,
int lookbackPeriods,
int? endIndex = null)
Expand Down Expand Up @@ -73,8 +71,7 @@ internal static double Increment<T>(
// TODO: apply this SMA increment method more widely in other indicators (see EMA example)
}

[ExcludeFromCodeCoverage]
[Category("Experimental")]
[ExcludeFromCodeCoverage] // experimental SIMD code
internal static double[] Increment(this double[] prices, int period)
{
// TODO: remove/consider experiment, has rounding errors
Expand Down

0 comments on commit 25c6881

Please sign in to comment.