Skip to content

Commit

Permalink
Election improvement: let the zk ephemeral node deleted immediately a…
Browse files Browse the repository at this point in the history
…fter connection closed
  • Loading branch information
pwzgorilla committed Sep 11, 2017
1 parent c432a16 commit 3f89b0f
Showing 1 changed file with 38 additions and 14 deletions.
52 changes: 38 additions & 14 deletions manager/manager.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
package manager

import (
"os"
"os/signal"
"path/filepath"
"strings"
"syscall"

"github.com/Dataman-Cloud/swan/api"
"github.com/Dataman-Cloud/swan/config"
Expand Down Expand Up @@ -125,6 +128,11 @@ func (m *Manager) Start() error {
}

func (m *Manager) start() error {
defer func() {
log.Println("close connection with zookeeper")
m.ZKClient.Close()
}()

go func() {
p, err := m.electLeader()
if err != nil {
Expand Down Expand Up @@ -161,24 +169,40 @@ func (m *Manager) start() error {
}
}()

for {
select {
case c := <-m.leadershipChangeCh:
switch c {
case LeadershipLeader:
if err := m.sched.Subscribe(); err != nil {
log.Errorf("subscribe to mesos leader error: %v", err)
m.errCh <- err
go func() {
for {
select {
case c := <-m.leadershipChangeCh:
switch c {
case LeadershipLeader:
if err := m.sched.Subscribe(); err != nil {
log.Errorf("subscribe to mesos leader error: %v", err)
m.errCh <- err
}

m.apiserver.UpdateLeader(m.leader)

case LeadershipFollower:
log.Warnln("became follower, closing all agents ...")
m.clusterMaster.CloseAllAgents()
m.apiserver.UpdateLeader(m.leader)
}
}
}
}()

m.apiserver.UpdateLeader(m.leader)

case LeadershipFollower:
log.Warnln("became follower, closing all agents ...")
m.clusterMaster.CloseAllAgents()
m.apiserver.UpdateLeader(m.leader)
// wait signal
sigChan := make(chan os.Signal)
signal.Notify(sigChan, syscall.SIGINT, syscall.SIGQUIT, syscall.SIGTERM, syscall.SIGUSR1)
for {
select {
case sig := <-sigChan:
switch sig {
case syscall.SIGUSR1:
continue
}

return nil
case err := <-m.errCh:
return err
}
Expand Down

0 comments on commit 3f89b0f

Please sign in to comment.