This repository has been archived by the owner on Oct 6, 2021. It is now read-only.
Headless mode to Selenium scraper. #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghuramdr
requested review from
kaizer1v,
yashodhan19,
SrivalyaElluru and
a team
1) Fetching `website_baseurl` variable in `ncs_scraper.py` file from `properties.ini` file 2) Updated README to add steps on how to run `ncs_scraper.py` file. :
Removed typo
Removed commented code which was not required
Changed the name of the argparse flag from -he to -f. -he can be confused for the --help argument.
Used argparse to specify command line arguments that fetches the name(s) of state(s) that we fetch datafor. Updated the README file to reflect these changes.
Added functionality to fetch specific states.
yashodhan19
reviewed
May 3, 2020
| @@ -1,6 +1,16 @@ | |||
| beautifulsoup4==4.7.1 | |||
| lxml>=4.3,<5 | |||
| requests==2.21.0 | |||
| certifi==2020.4.5.1 | |||
There was a problem hiding this comment.
Are all these direct dependencies or are they dependencies of packages installed
There was a problem hiding this comment.
Dependencies of packages.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #28.