Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synthetic stalls #4600

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Add synthetic stalls #4600

wants to merge 8 commits into from
+201 −14

Commits on Oct 16, 2024

  1. Add synthetic stalling (set playback rate to 0) when stream stalls 

    Co-authored-by: Joel Keers <[email protected]>
    @tom-coward @jlks
    tom-coward and jlks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9398da1 View commit details
    Browse the repository at this point in the history

  2. Add enableSyntheticStalls setting 

    Co-authored-by: Joel Keers <[email protected]>
    @tom-coward @jlks
    tom-coward and jlks committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7ce89d9 View commit details
    Browse the repository at this point in the history

  3. Add option to ignore ready state check for synthetic stalls 

    * also moves synthetic stall settings into syntheticStallEvents object

Co-authored-by: Eirik Bjornerstedt <[email protected]>

Co-authored-by: Joanne Monaghan <[email protected]>
    @tom-coward @jmonaghan85
    tom-coward and jmonaghan85 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b811ed3 View commit details
    Browse the repository at this point in the history

  4. Refactor setPlaybackRate to use waitForReadyState 

    * replaces listening for an canplay event manually, as has been done in other parts of VideoModel

Co-authored-by: Eirik Bjornerstedt <[email protected]>

Co-authored-by: Joanne Monaghan <[email protected]>
    @tom-coward @jmonaghan85
    tom-coward and jmonaghan85 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6e603ad View commit details
    Browse the repository at this point in the history

  5. Remove onPlaybackCanPlay from VideoModel interface

    @tom-coward
    tom-coward committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5fedc6d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Add tests for setPlaybackRate & setStallState in VideoModel

    @tom-coward
    tom-coward committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    606cd6b View commit details
    Browse the repository at this point in the history

  2. Add tests for synthetic stall playing events

    @tom-coward
    tom-coward committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    735ad6a View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Merge branch 'development' into badgers-upstream-552-synthetic-stalls

    @tom-coward
    tom-coward authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c64fb45 View commit details
    Browse the repository at this point in the history