Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PS env var for each process #156

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

blaedj
Copy link
Contributor

@blaedj blaedj commented Apr 26, 2023

This commit:

  • sets an OVERMIND_WORKER_NAME env var populated with the process name for each tmux cmd

Why?

  • It can be useful for each process to be able to reference its 'worker name' as specified in the Procfile.

Closes #148

There may be a cleaner way to do this than just manipulating the tmux command, I'm certainly open to any suggestions!

This commit:
 - sets an OVERMIND_WORKER_NAME env var populated with the worker name
 for each tmux process

Why?
 - It can be useful for each process to be able to reference its
 'worker name' as specified in the Procfile.
@jtwatson
Copy link

jtwatson commented May 6, 2023

@DarthSim This would be a nice feature to get merged! Is there something I can do to help get this merged? Thanks for the awesome tool!

@Envek Envek changed the title Set OVERMIND_WORKER_NAME env var for each process Set PS env var for each process Mar 5, 2024
@Envek Envek merged commit 0bc4fcb into DarthSim:master Mar 5, 2024
5 checks passed
@Envek
Copy link
Collaborator

Envek commented Mar 5, 2024

Thanks a lot for the pull request.

I changed place to define the variable to script file that already used to export PORT variable.

Also I renamed variable to PS for compatibility with the original foreman gem (see ddollar/foreman#340)

@blaedj
Copy link
Contributor Author

blaedj commented Mar 14, 2024

Awesome thanks so much!

@blaedj blaedj deleted the worker-name-env-var branch March 14, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: set env var containing Procfile "process type" name
3 participants