Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DemoCookies() waits on NID cookie existence #370

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

mlipok
Copy link
Contributor

@mlipok mlipok commented Aug 7, 2022

Pull request

Proposed changes

NID cookie may not exist at start, may appear later when website will be estabilished, so there is need to wait on @error and try again

Checklist

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

NID may not exist after even after _WD_LoadWait

What is the new behavior?

DemoCookies() waits on NID cookie existence

Additional context

wd_demo: review all "Demo****" function

System under test

not related

Copy link
Owner

@Danp2 Danp2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a way for this loop to exit after some period of time so that the script doesn't loop forever in the event that the cookie never "appears".

@Danp2 Danp2 merged commit 8f62b99 into Danp2:master Aug 8, 2022
@mlipok mlipok deleted the ml_DemoCookies_NID branch August 8, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants