fix: Correct position check of deprecation message (#190)

DannyvdSluijs · Apr 4, 2023 · 1630504 · 1630504
1 parent 17e6de6
commit 1630504
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/MetaDataTool/Command/MetaDataBuilderCommand.php b/MetaDataTool/Command/MetaDataBuilderCommand.php
@@ -7,7 +7,9 @@
 use MetaDataTool\Config\EndpointCrawlerConfig;
 use MetaDataTool\Crawlers\EndpointCrawler;
 use MetaDataTool\Crawlers\MainPageCrawler;
+use MetaDataTool\Enum\KnownEntities;
 use MetaDataTool\JsonFileWriter;
+use MetaDataTool\PageRegistry;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -53,6 +55,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $io->info(['Scanning main page', self::MAINPAGE]);
         $mainPageCrawler = new MainPageCrawler(self::MAINPAGE);
         $pages = $mainPageCrawler->run();
+        foreach (KnownEntities::keys() as $entity) {
+            $pages->add('https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=' . $entity);
+        }
 
         $io->info('Scanning entity pages');
         $io->progressStart($pages->count());

diff --git a/MetaDataTool/Crawlers/EndpointCrawler.php b/MetaDataTool/Crawlers/EndpointCrawler.php
@@ -120,7 +120,7 @@ private function crawlWebPage(string $url): ?Endpoint
 
         $goodToKnows = $this->domCrawler->filterXPath('//*[@id="goodToKnow"]');
         $deprecationMessage = 'This endpoint is redundant and is going to be removed.';
-        $isDeprecated = $goodToKnows->count() > 0 && strpos($goodToKnows->first()->text(), $deprecationMessage) === 0;
+        $isDeprecated = $goodToKnows->count() > 0 && strpos($goodToKnows->first()->text(), $deprecationMessage) !== false;
 
         return new Endpoint(
             $endpoint,

diff --git a/MetaDataTool/Enum/KnownEntities.php b/MetaDataTool/Enum/KnownEntities.php
@@ -149,6 +149,11 @@ class KnownEntities extends Enum
     private const SalesOrderSalesOrderLines = 'SalesOrderSalesOrderLines';
     private const SalesOrderSalesOrders = 'SalesOrderSalesOrders';
     private const SalesPriceLists = 'SalesPriceLists';
+    private const SalesSalesPriceListDetails = 'SalesSalesPriceListDetails';
+    private const SalesSalesPriceListLinkedAccounts = 'SalesSalesPriceListLinkedAccounts';
+    private const SalesSalesPriceListPeriods = 'SalesSalesPriceListPeriods';
+    private const SalesSalesPriceLists = 'SalesSalesPriceLists';
+    private const SalesSalesPriceListVolumeDiscounts = 'SalesSalesPriceListVolumeDiscounts';
     private const SalesShippingMethods = 'SalesShippingMethods';
     private const SubscriptionSubscriptionLines = 'SubscriptionSubscriptionLines';
     private const SubscriptionSubscriptionLineTypes = 'SubscriptionSubscriptionLineTypes';
@@ -157,6 +162,12 @@ class KnownEntities extends Enum
     private const SubscriptionSubscriptionRestrictionItems = 'SubscriptionSubscriptionRestrictionItems';
     private const SubscriptionSubscriptionTypes = 'SubscriptionSubscriptionTypes';
     private const SubscriptionSubscriptions = 'SubscriptionSubscriptions';
+    private const SyncCRMQuotationHeaders = 'SyncCRMQuotationHeaders';
+    private const SyncCRMQuotationLines = 'SyncCRMQuotationLines';
+    private const SyncCRMQuotations = 'SyncCRMQuotations';
+    private const SyncSalesOrderSalesOrderHeaders = 'SyncSalesOrderSalesOrderHeaders';
+    private const SyncSalesOrderSalesOrderLines = 'SyncSalesOrderSalesOrderLines';
+    private const SyncSalesOrderSalesOrders = 'SyncSalesOrderSalesOrders';
     private const SystemSystemDivisions = 'SystemSystemDivisions';
     private const SystemSystemMe = 'SystemSystemMe';
     private const UsersUserRoles = 'UsersUserRoles';