Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitgnore correctly set Practice for CPP #476

Closed
wants to merge 3 commits into from

Conversation

K-Kumar-01
Copy link
Contributor

Description

Added the gitignore correctly set practice for CPP and the spec file.

Motivation and Context

#411

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have added new practice to practice list in README.md.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

createTestContainer,
} from '../../inversify.config';

const basicGitignore = `*.d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's there if you don't use it anywhere?

Comment on lines +73 to +91
prerequisitesRegex &&
sloRegex &&
loRegex &&
oRegex &&
objRegex &&
gchHeaderRegex &&
pchHeaderRegex &&
soRegex &&
dylibRegex &&
dllRegex &&
modRegex &&
smodRegex &&
laiRegex &&
laRegex &&
aRegex &&
libRegex &&
exeRegex &&
outRegex &&
appRegex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't check all these things. C++ works differently on every platform (operation system), so users should ignore different things on different platforms. It would be more difficult than this.

@K-Kumar-01
Copy link
Contributor Author

@adelkahomolova
So is there any basic gitgnore which will be same for all, for which we can check or is there any other thing i have to do here?

@adelkahomolova
Copy link
Contributor

I don't think so, @K-Kumar-01 . I think it will be quite difficult to check it properly. We don't want to force users to add some properties they don't need in their .gitignore, so it's about finding the right .gitignore for each platform and check if there is at least one of the property there. E.g. we should check, that there is one of these in the .gitignore.

*.so // linux 
*.dylib // macos
*.dll // windows

And we need to find what all must be there.

@adelkahomolova
Copy link
Contributor

Also, do you run the tests before you make PRs in our repo? @K-Kumar-01

@K-Kumar-01
Copy link
Contributor Author

I don't think so, @K-Kumar-01 . I think it will be quite difficult to check it properly. We don't want to force users to add some properties they don't need in their .gitignore, so it's about finding the right .gitignore for each platform and check if there is at least one of the property there. E.g. we should check, that there is one of these in the .gitignore.

*.so // linux 
*.dylib // macos
*.dll // windows

And we need to find what all must be there.

Okay i will try to see if i can figure this one out

@K-Kumar-01
Copy link
Contributor Author

Also, do you run the tests before you make PRs in our repo? @K-Kumar-01

I am sorry but i did not ran test in this one. In the previous ones i made the test. I will make sure to run the tests from now on.

@adelkahomolova
Copy link
Contributor

Hi, @K-Kumar-01 , is there any progress? :)

@K-Kumar-01
Copy link
Contributor Author

Hi, @K-Kumar-01 , is there any progress? :)

Had been a busy due to some college stuff lately. Will work on it ASAP.

@adelkahomolova
Copy link
Contributor

Sure, no worries, no rush :) @K-Kumar-01

@adelkahomolova
Copy link
Contributor

adelkahomolova commented Dec 9, 2020

@K-Kumar-01 Hi, have you had time to work on it? Or will you?

@K-Kumar-01
Copy link
Contributor Author

@adelkahomolova Sorry Adela In the midst of my exams I forgot about the issue.
However, I won't be able to work on the issue further due to some prior work.
I apologize for the delay caused by me. You can assign this issue to someone else as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants