-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitgnore correctly set Practice for CPP #476
Conversation
createTestContainer, | ||
} from '../../inversify.config'; | ||
|
||
const basicGitignore = `*.d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's there if you don't use it anywhere?
prerequisitesRegex && | ||
sloRegex && | ||
loRegex && | ||
oRegex && | ||
objRegex && | ||
gchHeaderRegex && | ||
pchHeaderRegex && | ||
soRegex && | ||
dylibRegex && | ||
dllRegex && | ||
modRegex && | ||
smodRegex && | ||
laiRegex && | ||
laRegex && | ||
aRegex && | ||
libRegex && | ||
exeRegex && | ||
outRegex && | ||
appRegex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't check all these things. C++ works differently on every platform (operation system), so users should ignore different things on different platforms. It would be more difficult than this.
@adelkahomolova |
I don't think so, @K-Kumar-01 . I think it will be quite difficult to check it properly. We don't want to force users to add some properties they don't need in their
And we need to find what all must be there. |
Also, do you run the tests before you make PRs in our repo? @K-Kumar-01 |
Okay i will try to see if i can figure this one out |
I am sorry but i did not ran test in this one. In the previous ones i made the test. I will make sure to run the tests from now on. |
Hi, @K-Kumar-01 , is there any progress? :) |
Had been a busy due to some college stuff lately. Will work on it ASAP. |
Sure, no worries, no rush :) @K-Kumar-01 |
@K-Kumar-01 Hi, have you had time to work on it? Or will you? |
@adelkahomolova Sorry Adela In the midst of my exams I forgot about the issue. |
Description
Added the gitignore correctly set practice for CPP and the spec file.
Motivation and Context
#411
Types of changes
Checklist: