Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Practice: Gitignore practice for C++ #411

Open
prokopsimek opened this issue Sep 30, 2020 · 10 comments
Open

New Practice: Gitignore practice for C++ #411

prokopsimek opened this issue Sep 30, 2020 · 10 comments

Comments

@prokopsimek
Copy link
Member

New Practice Proposal

Create a new practice that checks correctly set .gitignore for C++.

@prokopsimek prokopsimek self-assigned this Sep 30, 2020
@prokopsimek prokopsimek removed their assignment Sep 30, 2020
@iamRishabh07
Copy link

Hi @prokopsimek I would like to work on this issue.

@prokopsimek
Copy link
Member Author

@iamRishabh07 Sure! Go ahead! 👏

@iamRishabh07
Copy link

@prokopsimek How do I reproduce this error.

@adelkahomolova
Copy link
Contributor

@iamRishabh07 It's not an error. You should create a new practice. Code that checks, that you have correctly set .gitignore in C++ repository. See practices for other languages in the folder src/practices. Our whole project is in Typescript as you can see on the main page on GitHub.

@iamRishabh07
Copy link

@adelkahomolova @prokopsimek can you guide me I am having some difficulty while trying to solve this issue.

@adelkahomolova
Copy link
Contributor

@iamRishabh07 What about trying to resolve my comments on Pull requests that you already made? :) I tried to guide you there. Let me now, if there is anything else I can help you with.
I can guide you on this issue when you finish the job you've already started. :)
So look at this PR you made PR 434 and this one you made PR 435

@iamRishabh07
Copy link

@adelkahomolova I am working on that issue.

@K-Kumar-01
Copy link
Contributor

@adelkahomolova
The last conversation seems a few weeks back.
If the issue is still open, can i work on it?

@adelkahomolova
Copy link
Contributor

I think, that you can. It's yours, @K-Kumar-01

@K-Kumar-01
Copy link
Contributor

@adelkahomolova
I have made the PR. Let me know if there are any changes required.

@prokopsimek prokopsimek removed the Hacktoberfest https://hacktoberfest.digitalocean.com label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants