Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make output of import contest more readable. #2777

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meisterT
Copy link
Member

@meisterT meisterT commented Nov 3, 2024

Print the output of zip line by line, overwriting the last line and removing all output of it on success.

Also pretty-print the JSON response on problem output.

That makes it much easier to see warnings or errors.

Fixes #2342.

@vmcj
Copy link
Member

vmcj commented Nov 3, 2024

To make sure I understand it correctly, can you send a demonstration (gif/movie)?

@meisterT
Copy link
Member Author

meisterT commented Nov 3, 2024

Print the output of `zip` line by line, overwriting the last line and
removing all output of it on success.

Also pretty-print the JSON response on problem output.

That makes it much easier to see warnings or errors.

Fixes DOMjudge#2342.
Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed already a huge improvement. I'll see with my next contest if this is enough, you didn't have any errors here right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import-contest should create an upload log
3 participants