Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show MySQL variables, also if check is ok #2761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eldering
Copy link
Member

This helps quickly inspecting settings, in my case for example the MySQL transaction isolation level.
We should probably do this for all configuration settings.

This helps quickly inspecting settings, in my case for example
the MySQL transaction isolation level.
We should probably do this for all configuration settings.
@@ -222,34 +222,42 @@ public function checkMysqlSettings(): ConfigCheckItem
$desc = '';
if ($vars['max_connections'] < 300) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write these to reduce duplication:

$desc .= sprintf("max_connections is set to %s.\n", $vars['max_connections']);
if ($vars['max_connections'] < 300) {
            $result = 'W';
            $desc .= sprintf("In our experience you need at least 300, but better 1000 connections to prevent connection refusal during the contest.\n", $vars['max_connections']);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants