Construct ZIP files while uploading executables. #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an improvement on top of DOMjudge#2129, since you do not need to check in ZIP files into a ccsconfig repository, but directories which are zipped up on the fly. This makes changing and reviewing changes much easier.
vmcj
approved these changes
Sep 3, 2023
|
I thought about it, but the old thing has been around for a week, so the number of users is probably just me :-) |
nickygerritsen
approved these changes
Sep 3, 2023
Ok, I thought this was also in a released version. Than ripping it out is preferred. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement on top of #2129, since you do not need to check in ZIP files into a ccsconfig repository, but directories which are zipped up on the fly.
This makes changing and reviewing changes much easier.