Update score and rank of all teams of the contest after rejudging. #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
force-pushed
the
rejudging-update-scorecache
branch
from
e432211
to
62a0645
Compare
This makes sure the rank and first to solve of all teams are correctly set. Fixes DOMjudge#2105.
nickygerritsen
force-pushed
the
rejudging-update-scorecache
branch
from
62a0645
to
c579c43
Compare
vmcj
reviewed
Aug 24, 2023
| // Finally, get the scoreboard again and test if the first to solve changed | ||
| $scoreboard = $scoreboardService->getScoreboard($contest, true); | ||
|
|
||
| static::assertFalse($scoreboard->solvedFirst($team1, $contestProblem)); |
There was a problem hiding this comment.
Before this failed right? We would have 2 teams with solvedFirst.
There was a problem hiding this comment.
Exactly, this is the line that failed.
vmcj
reviewed
Aug 24, 2023
meisterT
reviewed
Aug 26, 2023
|
But the rank of teams can also change right? |
|
True. How did we never run into this issue then? |
🤷♂️ |
meisterT
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the rank and first to solve of all teams are correctly set.
Fixes #2105.