Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix env_checker function for gymnasium FrameStacked observations (previously raised an error)
Description
FrameStacked obs from Gymnasium only support Box obs and are stored in a LazyFrames class. Because the associated obs_space is a np.ndarray, I only added a condition where I still check if the obs is a np.ndarray class, but also a LazyFrames class (when _is_numpy_array_space is True).
@qgallouedec also proposed to use np.can_cast which worked, but the type hinting for the function became really long (and could lead to errors) because you can also cast str, bytes ... So I don't know if the solution used here is the best but it seems to work. What do you think about it ?
Motivation and Context
Solves the problem mentionned in this issue.
closes #1500
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required) --> I don't have a GPU and had a segmentation error by running 'make pytest'make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line