Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] fix: from mambaforge to miniforge #7869

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Nov 1, 2024

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Nov 1, 2024
@aldbr aldbr linked an issue Nov 1, 2024 that may be closed by this pull request
@aldbr
Copy link
Contributor

aldbr commented Nov 1, 2024

I've just realized that #7837 only targeted integration 😅

Btw, I am not entirely sure that this comment has been addressed: #7837 (comment)

@fstagni
Copy link
Contributor Author

fstagni commented Nov 1, 2024

Well I did not change the Action like it was done in Chris' PR.

The documentation should be updated also, but TBH I am feeling lazy...

@fstagni fstagni marked this pull request as ready for review November 1, 2024 16:29
@fstagni fstagni changed the title fix: from mambaforge to miniforge [8.0] fix: from mambaforge to miniforge Nov 1, 2024
@chrisburr chrisburr merged commit bb24b5c into DIRACGrid:rel-v8r0 Nov 4, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Nov 4, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/11658802099

Failed:

  • integration
    cherry-pick bb24b5c into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-bb24b5c9a-integration
    git cherry-pick -x -m 1 bb24b5c9a
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7869 fix: from mambaforge to miniforge' --author='Federico Stagni <[email protected]>'
    git push -u origin cherry-pick-2-bb24b5c9a-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] fix: from mambaforge to miniforge' \
         --body 'Sweep #7869 `fix: from mambaforge to miniforge` to `integration`.
    
    Adding original author @fstagni as watcher.
    
    
    Closes #7870'

fstagni added a commit to fstagni/DIRAC that referenced this pull request Nov 4, 2024
fstagni added a commit to fstagni/DIRAC that referenced this pull request Nov 4, 2024
fstagni added a commit to fstagni/DIRAC that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing Mambaforge with Miniforge?
4 participants