-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] Change the updating logic of the TS FileStatus #7741
Conversation
7d9bfd6
to
eb238b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions for my understanding.
Do you mean
Implement getBulkRequestStatus
In the release notes?
else: | ||
badRequestID += 1 | ||
# We don't care updating the tasks to Assigned while the request is being processed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify this comment?
I don't understand what we "don't care" about here?
Or like:
# We don't care updating the tasks to Assigned while the request is being processed | |
# We do not update the tasks to Assigned while the request is being processed |
But why? (what is the status while it is being processed?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Assigned
for the RMS request, that is, it is currently bewing treated by the REA, so it is a very temporary status
d9c89d9
to
7af5cfc
Compare
e556b44
to
61c555f
Compare
b40ad4b
to
69cf9d2
Compare
69cf9d2
to
4909f05
Compare
4909f05
to
3652097
Compare
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/10993993193 Failed:
|
This aims at solving #7116
It is quite a big change of logic, but should not impact anybody but LHCb, as it mostly matters for complex body plugin
Also, it speeds up a lot the RequestTaskAgent.
Hotfixed in LHCb, we observe a huge speedup on a transformation with 4M files:
BEGINRELEASENOTES
*TS
FIX: RequestTaskAgent only considers requests in final states, and consider files in intermediate state as problematic (#7116)
NEW: RequestTaskAgent uses getBulkRequestStatus instead of getRequestStatus
RMS:
NEW: implement getRequestStatus
ENDRELEASENOTES