Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] JobDB: update LastUpdateTime when the job is matched #7701

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Jun 26, 2024

This (commit 9125b4b) fixes an obscure bug that was unfolding like the following:

  1. Job X went to status "Waiting" at time T
  2. Job X was finally matched at time T + Y (with Y more than 2 hours)
    • no update of LastUpdateTime field in JobDB, which was staying at time T
    • the job normally stays in status Matched only few seconds, before going to "Running"
  3. StalledJobAgent looks, among other tasks, at jobs possibly stuck in status "Matched" for more than 2 hours, rescheduling them
    • if that happens in those few seconds when the status was "Matched" but the LastUpdateTime still T, those jobs were rescheduled.

BEGINRELEASENOTES

*WMS
FIX: JobDB: update LastUpdateTime when the job is matched

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Jun 26, 2024
@fstagni fstagni merged commit 2c4c947 into DIRACGrid:rel-v8r0 Jun 27, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Jun 27, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9694203659

Failed:

  • integration
    cherry-pick 2c4c947 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-2c4c947b5-integration
    git cherry-pick -x -m 1 2c4c947b5
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7701 JobDB: update LastUpdateTime when the job is matched' --author='Federico Stagni <[email protected]>'
    git push -u origin cherry-pick-2-2c4c947b5-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] JobDB: update LastUpdateTime when the job is matched' \
         --body 'Sweep #7701 `JobDB: update LastUpdateTime when the job is matched` to `integration`.
    
    Adding original author @fstagni as watcher.
    
    BEGINRELEASENOTES
    
    *WMS
    FIX:  JobDB: update LastUpdateTime when the job is matched
    
    ENDRELEASENOTES
    Closes #7705'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants