Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] HTCondorCE: fix HOME for useSSL #7675

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

andresailer
Copy link
Contributor

I managed to run some jobs at CERN with the UseSSLSubmission and the help of the CERN batch people.
But the two processes I checked don't have HOME in their environ on the dirac servers, mine or lbcertifdirac. So I propose to fix the location of the files here.

BEGINRELEASENOTES
*Resources
FIX: HTCondorCE: fix exception when UseSSLSubmission is true. The SiteDirector environment does not have HOME. Always use /home/dirac/.globus to get userkey and usercert files.
*Core
FIX: Locations.getCertificateAndKeyLocation: fix exception when HOME is not set.

ENDRELEASENOTES

fix exception when running without HOME variable
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Jun 17, 2024
… does not have HOME environment variable

This prevents an exception.

Alternatively could give a default value for getCertificateAndKeyLocation, but that ends up just hardcoding it as well.
Using SSL is only a temporary solution (and other lies we tell ourselves)
@fstagni fstagni merged commit 34d5e05 into DIRACGrid:rel-v8r0 Jun 18, 2024
26 checks passed
@andresailer andresailer deleted the 80_fixHome branch June 18, 2024 10:47
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Jun 18, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9563646367

Failed:

  • integration
    cherry-pick 34d5e05 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-34d5e0515-integration
    git cherry-pick -x -m 1 34d5e0515
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7675 HTCondorCE: fix HOME for useSSL' --author='Andre Sailer <[email protected]>'
    git push -u origin cherry-pick-2-34d5e0515-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] HTCondorCE: fix HOME for useSSL' \
         --body 'Sweep #7675 `HTCondorCE: fix HOME for useSSL` to `integration`.
    
    Adding original author @andresailer as watcher.
    
    BEGINRELEASENOTES
    *Resources
    FIX: HTCondorCE: fix exception when UseSSLSubmission is true. The SiteDirector environment does not have HOME. Always use /home/dirac/.globus to get userkey and usercert files.
    *Core
    FIX: Locations.getCertificateAndKeyLocation: fix exception when HOME is not set.
    
    ENDRELEASENOTES
    Closes #7676'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants