Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] fix for pylint 3.2.0 #7614

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

chaen
Copy link
Contributor

@chaen chaen commented May 14, 2024

BEGINRELEASENOTES
*All
FIX: fix pylint 3.2.0 warnings

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label May 14, 2024
@chaen chaen marked this pull request as ready for review May 15, 2024 07:41
@@ -174,6 +174,8 @@ def _printDiff(self, entry, level=""):
diffType, entryName, _value, changes, _comment = entry
elif len(entry) == 4:
diffType, entryName, _value, changes = entry
else:
raise ValueError(f"Invalid entry {entry}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ValueError(f"Invalid entry {entry}")
raise NotImplementedError(f"Invalid entry {entry}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of ValueError seems more fitting:

Raised when an operation or function receives an argument that has the right type but an inappropriate value

@fstagni fstagni merged commit a279572 into DIRACGrid:rel-v8r0 May 15, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels May 15, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9093671586

Failed:

  • integration
    cherry-pick a279572 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-a27957284-integration
    git cherry-pick -x -m 1 a27957284
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7614 fix for pylint 3.2.0 ' --author='Christophe Haen <[email protected]>'
    git push -u origin cherry-pick-2-a27957284-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] fix for pylint 3.2.0 ' \
         --body 'Sweep #7614 `fix for pylint 3.2.0 ` to `integration`.
    
    Adding original author @chaen as watcher.
    
    BEGINRELEASENOTES
    *All
    FIX: fix pylint 3.2.0 warnings
    
    ENDRELEASENOTES
    Closes #7615'

chaen added a commit to chaen/DIRAC that referenced this pull request May 15, 2024
chaen added a commit to chaen/DIRAC that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants