-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] fix for pylint 3.2.0 #7614
Conversation
0cbe0a5
to
a87a819
Compare
@@ -174,6 +174,8 @@ def _printDiff(self, entry, level=""): | |||
diffType, entryName, _value, changes, _comment = entry | |||
elif len(entry) == 4: | |||
diffType, entryName, _value, changes = entry | |||
else: | |||
raise ValueError(f"Invalid entry {entry}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise ValueError(f"Invalid entry {entry}") | |
raise NotImplementedError(f"Invalid entry {entry}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition of ValueError
seems more fitting:
Raised when an operation or function receives an argument that has the right type but an inappropriate value
a87a819
to
c9cf7dd
Compare
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9093671586 Failed:
|
BEGINRELEASENOTES
*All
FIX: fix pylint 3.2.0 warnings
ENDRELEASENOTES