Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Support token transfers in FTS #7440

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Feb 6, 2024

Needs
https://gitlab.cern.ch/fts/fts-rest-flask/-/merge_requests/116

Requires an sql update

alter table Files CHANGE `status` `status` enum('New','Submitted','Ready','Active','Finished','Canceled','Staging','Failed','Defunct','Started','Not_used','Archiving', 'Token_prep') DEFAULT 'New'

BEGINRELEASENOTES

*DMS
NEW: experimental token support for FTS transfers

*Framework

NEW: allow to bypass cache when retrieving tokens

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Feb 6, 2024
@chaen chaen changed the title [8.0] feat fts3 token submit [8.0] Support token transfers in FTS Feb 7, 2024
@chaen chaen force-pushed the v8.0_FEAT_fts3TokenSubmit branch 3 times, most recently from 0d782ab to f212843 Compare February 12, 2024 13:49
@chaen chaen force-pushed the v8.0_FEAT_fts3TokenSubmit branch 2 times, most recently from 4f656e4 to faf2eb5 Compare March 7, 2024 14:14
@chaen chaen force-pushed the v8.0_FEAT_fts3TokenSubmit branch from faf2eb5 to c6f60da Compare May 16, 2024 14:59
@chaen chaen force-pushed the v8.0_FEAT_fts3TokenSubmit branch 2 times, most recently from ac24b33 to 3dad8ff Compare June 25, 2024 13:42
@chaen
Copy link
Contributor Author

chaen commented Jun 25, 2024

So, following the workshop, opinion on having that merged in ?

@chaen chaen marked this pull request as ready for review June 25, 2024 14:42
@fstagni
Copy link
Contributor

fstagni commented Jun 25, 2024

This requires an SQL update, so it should be a bit more carefully announced.

@chaen
Copy link
Contributor Author

chaen commented Jun 28, 2024

This requires an SQL update, so it should be a bit more carefully announced.

Sure ! But I'd still like to have other communities (@andresailer @marianne013 @atsareg ) using this system giving their input

Copy link
Contributor

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is isolated to the rest of the code, so I have no objection for merging it.

@fstagni
Copy link
Contributor

fstagni commented Aug 13, 2024

Is this finally ready for merge?

@marianne013
Copy link
Contributor

I just had a quick chat with Simon and his answer basically amounted to a shrug, so go ahead (FYI @sfayer)

fstagni
fstagni previously approved these changes Sep 11, 2024
@fstagni fstagni merged commit 4057543 into DIRACGrid:rel-v8r0 Oct 7, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Oct 7, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/11216631777

Failed:

  • integration
    cherry-pick 4057543 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-405754371-integration
    git cherry-pick -x -m 1 405754371
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7440 Support token transfers in FTS' --author='Christophe Haen <[email protected]>'
    git push -u origin cherry-pick-2-405754371-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Support token transfers in FTS' \
         --body 'Sweep #7440 `Support token transfers in FTS` to `integration`.
    
    Adding original author @chaen as watcher.
    
    BEGINRELEASENOTES
    
    *DMS
    NEW: experimental token support for FTS transfers
    
    *Framework
    
    NEW: allow to bypass cache when retrieving tokens
    
    ENDRELEASENOTES
    Closes #7816'

chaen added a commit to chaen/DIRAC that referenced this pull request Oct 7, 2024
chaen added a commit to chaen/DIRAC that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants