[integration] add a wnVO argument to sendMessage and finaliseLogs #7425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstagni
reviewed
Jan 29, 2024
Comment on lines
+71
to
+72
| if vo == "": | ||
| vo = wnVO |
There was a problem hiding this comment.
In theory, we could have the case where vo is different from wnVO...
|
Well, if it’s only a matter of a variable name, that’s not a big problem.
We have to be sure what value to pass from the pilot end..
J.
…On Mon, 29 Jan 2024 at 12:48, Federico Stagni ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
src/DIRAC/WorkloadManagementSystem/Service/TornadoPilotLoggingHandler.py
<#7425 (comment)>:
> + if vo == "":
+ vo = wnVO
In theory, we *could* have the case where vo is different from wnVO...
—
Reply to this email directly, view it on GitHub
<#7425 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2KE7KGH4VIQ7SUCRHORT3YQ6D7ZAVCNFSM6AAAAABCMQARK6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBYGQ4DGNJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fstagni
approved these changes
Jan 30, 2024
It's probably not an issue... approved and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*WorkloadManagementSystem
NEW: TornadoPilotLoggingHandler modify the handler to accept VO name sent by a pilot. Required in a case where the VO cannot be guessed from a proxy. This change requires DIRACGrid/Pilot#230
ENDRELEASENOTES