Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1] Drop support for python 3.9 and 3.10? #7211

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

aldbr
Copy link
Contributor

@aldbr aldbr commented Sep 21, 2023

Do we still want to support python 3.9?

BEGINRELEASENOTES
ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 21, 2023
@chrisburr
Copy link
Member

I don't feel strongly either way but if we remove it we should also edit here:

DIRAC/setup.cfg

Lines 17 to 24 in d011057

Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Topic :: Scientific/Engineering
Topic :: System :: Distributed Computing
[options]
python_requires = >=3.9

@fstagni
Copy link
Contributor

fstagni commented Sep 21, 2023

We can remove from integration branch only.

@aldbr aldbr changed the title [8.0] remove ci test related to python 3.9 [8.0] Drop support for python 3.9? Sep 21, 2023
@aldbr aldbr changed the title [8.0] Drop support for python 3.9? [8.0] Drop support for python 3.9 and 3.10? Sep 21, 2023
@aldbr aldbr changed the base branch from rel-v8r0 to integration September 21, 2023 11:42
@aldbr
Copy link
Contributor Author

aldbr commented Sep 21, 2023

We can remove from integration branch only.

I changed the base branch: integration is now used.

I proposed this PR because I am getting used to the new typing syntax that we are using in diracx and I am starting to use it in DIRAC. And because there are a few differences between typing in py3.9 and py3.10-11 (e.g. Optional[str] vs str | None), it becomes "mentally difficult" to switch from one to the other.

Either developers just don't use the typing in DIRAC/use it with the py3.9 syntax, or we drop support for py3.9.

@fstagni fstagni changed the title [8.0] Drop support for python 3.9 and 3.10? [8.1] Drop support for python 3.9 and 3.10? Sep 22, 2023
@aldbr aldbr added sweep:ignore Prevent sweeping from being ran for this PR and removed alsoTargeting:integration Cherry pick this PR to integration after merge labels Sep 22, 2023
Copy link
Contributor

@fstagni fstagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong with this. If there's a different opinion, leave it below, merging early next week.

@fstagni fstagni merged commit 3a055e3 into DIRACGrid:integration Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants