[v8.1] Make Job.setNumberOfProcessors safer to use #7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LHCb we had issues with a user submitting jobs with
Job.setNumberOfProcessors(minProc=10, maxProc=1). This resulted in the job only requesting one CPU and caused complaints from sites.I think we should just make this API safer to use by rejecting values which aren't valid with an exception.
Any thoughts?
BEGINRELEASENOTES
*WorkloadManagement
CHANGE: Job.setNumberOfProcessors raises an exception if the function arguments aren't valid.
ENDRELEASENOTES