Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1] Make TaskQueueDB VO aware for diracx transition #7190

Merged

Conversation

simon-mazenoux
Copy link
Contributor

@simon-mazenoux simon-mazenoux commented Sep 6, 2023

This will require DB changes.

BEGINRELEASENOTES

*WMS
CHANGE: add VO info in TaskQueueDB

ENDRELEASENOTES

This PR was created for the purpose of getting some values from the Registry config (which is now VO specific in diracx) when deleting a TaskQueue to ajust the job shares correction.

@simon-mazenoux
Copy link
Contributor Author

Should I also create a script to fill the new VO column ? This way, we could make sure that every row has a VO, and it would avoid having hacky workarounds in diracx to figure out the VO from the group.

@simon-mazenoux simon-mazenoux changed the title feat: make TaskQueueDB VO aware for diracx transition [8.1] Make TaskQueueDB VO aware for diracx transition Sep 6, 2023
@simon-mazenoux
Copy link
Contributor Author

I just added the migration procedure in the wiki (https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-8.1#wms), so once this is reviewed, this is ready to be merged.

@fstagni
Copy link
Contributor

fstagni commented Sep 12, 2023

I just added the migration procedure in the wiki (https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-8.1#wms), so once this is reviewed, this is ready to be merged.

The script that you added in the wiki could be simplified, like the one in https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-8.1#remove-of-diracsetup-and-ownerdn-in-wms-and-transformations.

I would actually suggest to merge the 2 scripts into 1 to avoid double work for the sysadmins.

@simon-mazenoux
Copy link
Contributor Author

I just added the migration procedure in the wiki (https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-8.1#wms), so once this is reviewed, this is ready to be merged.

The script that you added in the wiki could be simplified, like the one in https://github.com/DIRACGrid/DIRAC/wiki/DIRAC-8.1#remove-of-diracsetup-and-ownerdn-in-wms-and-transformations.

I would actually suggest to merge the 2 scripts into 1 to avoid double work for the sysadmins.

I choose to write the script this way because, given that the WMS in DIRAC doesn't take advantage of the new field, then the person in charge of the migration doesn't need to stop any service to apply this change. One just needs to add the VO column before the 8.1 migration, and launch the second part of the script after the migration.

However, if you think it is easier for an administrator to stop services and run all the DB commands at once, then I will promptly modify my script.

@fstagni fstagni merged commit d2a29a7 into DIRACGrid:integration Sep 25, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants