Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] use python 3.11 by default #7136

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Jul 27, 2023

No description provided.

@fstagni fstagni requested a review from atsareg as a code owner July 27, 2023 13:10
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Jul 27, 2023
@fstagni fstagni requested a review from chaen as a code owner July 27, 2023 13:58
@fstagni
Copy link
Contributor Author

fstagni commented Jul 27, 2023

@andresailer would you have an idea about the doc fails now?

@andresailer
Copy link
Contributor

These warnings probably:

/home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/7136/src/DIRAC/FrameworkSystem/private/standardLogging/LogLevels.py:docstring of DIRAC.FrameworkSystem.private.standardLogging.LogLevels.LogLevel.from_bytes:9: WARNING: Inline interpreted text or phrase reference start-string without end-string.
/home/docs/checkouts/readthedocs.org/user_builds/dirac/checkouts/7136/src/DIRAC/FrameworkSystem/private/standardLogging/LogLevels.py:docstring of DIRAC.FrameworkSystem.private.standardLogging.LogLevels.LogLevel.to_bytes:8: WARNING: Inline interpreted text or phrase reference start-string without end-string.

@andresailer
Copy link
Contributor

This is an inherited docstring from a builtin(?, enum). I need to remember how to deal with that...

@fstagni
Copy link
Contributor Author

fstagni commented Jul 28, 2023

@andresailer
Copy link
Contributor

That doesn't fix it, trying locally now...

docs/docs.conf Outdated Show resolved Hide resolved
docs/docs.conf Outdated Show resolved Hide resolved
@andresailer
Copy link
Contributor

That should do it...
This is what the page looked like before, so ignoring inherited here should make no difference.

https://dirac.readthedocs.io/en/latest/CodeDocumentation/FrameworkSystem/private/standardLogging/LogLevels.html

@andresailer
Copy link
Contributor

This is what it would look like with inherited functions.
image

@fstagni
Copy link
Contributor Author

fstagni commented Jul 28, 2023

Fine for me, thanks @andresailer

For everyone else, a few bullets:

  • we moved DIRACOS to python3.11 before doing this PR. I think we should have done the contrary.
  • merging this would mean that the mamba env used for local developments would need to be recreated. This is easy but @DIRACGrid/dirac-developer should be aware

@@ -16,6 +16,7 @@ classifiers =
Programming Language :: Python :: 3
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to bump python_requires? Or let Python 3.9 continue on a best-effort basis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to continue 3.9.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case shall we at least leave a pylint (and possibly a pytest) job lying around for Python 3.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case shall we at least leave a pylint (and possibly a pytest) job lying around for Python 3.9

Just added them.

@chrisburr chrisburr merged commit c225c5d into DIRACGrid:rel-v8r0 Aug 3, 2023
20 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Aug 3, 2023
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/5748948960

Failed:

  • integration
    cherry-pick c225c5d into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-c225c5d3e-integration
    git cherry-pick -x -m 1 c225c5d3e
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7136 use python 3.11 by default' --author='fstagni <[email protected]>'
    git push -u origin cherry-pick-2-c225c5d3e-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] use python 3.11 by default' \
         --body 'Sweep #7136 `use python 3.11 by default` to `integration`.
    
    Adding original author @fstagni as watcher.
    
    
    Closes #7154'

fstagni added a commit to fstagni/DIRAC that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants