Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntheticDevice to UserDevice #214

Merged
merged 18 commits into from
Oct 13, 2023
Merged

Conversation

0xdev22
Copy link
Contributor

@0xdev22 0xdev22 commented Oct 10, 2023

db synth_devices
grpc user_devices list
single user_device

Proposed Changes

Impacted Routes

Caveats

@linear
Copy link

linear bot commented Oct 10, 2023

SI-2084 Expose synthetic device information through gRPC

Add a field to the user device gRPC response that describes the attached synthetic device, if there is one.

{
  "id": "2W880ZeTvD12GtbVELoXu7TOG4N",
  // …
  "syntheticDevice": {
    "tokenId": 44
    "integrationTokenId": 1
  }
}

Make sure that this works for both the “list user’s devices” endpoint and the “get this specific device” endpoint.

The code for these things is all here.

@@ -176,7 +176,7 @@ func (s *ConsumerTestSuite) TestVinCredentialerHandler_DeviceFingerprint() {
VehicleNFT: nft,
AftermarketDevice: aftermarketDevice,
},
{
/* {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge in main when you get the chance. We're just going to skip this until we can remove the dependency on the net.

@elffjs
Copy link
Member

elffjs commented Oct 11, 2023

The slot will conflict with Allyson. We will cross that bridge when the other one gets merged.

@0xdev22 0xdev22 requested a review from elffjs October 11, 2023 17:22
internal/services/fingerprint/consumer_test.go Outdated Show resolved Hide resolved
pkg/grpc/user_devices.proto Outdated Show resolved Hide resolved
pkg/grpc/user_devices.proto Outdated Show resolved Hide resolved
@0xdev22 0xdev22 requested a review from elffjs October 12, 2023 15:18
@elffjs
Copy link
Member

elffjs commented Oct 12, 2023

@Allyson-English Could you take a quick look?

@elffjs elffjs merged commit a46e585 into main Oct 13, 2023
2 checks passed
@elffjs elffjs deleted the SI-2084-expose-synthetic-device branch October 13, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants