-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntheticDevice to UserDevice #214
Conversation
SI-2084 Expose synthetic device information through gRPC
Add a field to the user device gRPC response that describes the attached synthetic device, if there is one.
Make sure that this works for both the “list user’s devices” endpoint and the “get this specific device” endpoint. The code for these things is all here. |
@@ -176,7 +176,7 @@ func (s *ConsumerTestSuite) TestVinCredentialerHandler_DeviceFingerprint() { | |||
VehicleNFT: nft, | |||
AftermarketDevice: aftermarketDevice, | |||
}, | |||
{ | |||
/* { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge in main when you get the chance. We're just going to skip this until we can remove the dependency on the net.
The slot will conflict with Allyson. We will cross that bridge when the other one gets merged. |
…work/devices-api into SI-2084-expose-synthetic-device
@Allyson-English Could you take a quick look? |
Proposed Changes
Impacted Routes
Caveats