Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-2027 Handle aftermarket serial event #203

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

elffjs
Copy link
Member

@elffjs elffjs commented Sep 13, 2023

Proposed Changes

Impacted Routes

Caveats

@elffjs elffjs marked this pull request as ready for review September 13, 2023 23:14
@linear
Copy link

linear bot commented Sep 13, 2023

SI-2027 Read aftermarket serial from events

Minting an aftermarket device should generate an event

AftermarketDeviceAttributeSet(tokenId, "Serial", serial)

Attach this to the device.

Because of the ordering and the lack of enforcement on-chain, we probably have to make serial optional in the table.

@elffjs elffjs merged commit d671e72 into main Sep 13, 2023
2 checks passed
@elffjs elffjs deleted the feature/si-2027-read-aftermarket-serial-from-events branch September 13, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant