Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRO-1892] call valuations api grpc endpoints #192

Merged
merged 4 commits into from
Aug 30, 2023
Merged

[PRO-1892] call valuations api grpc endpoints #192

merged 4 commits into from
Aug 30, 2023

Conversation

Asfiroth
Copy link
Member

Proposed Changes

  • call valuations api grpc endpoints

Impacted Routes

Caveats

@Asfiroth Asfiroth marked this pull request as ready for review August 29, 2023 22:32
@linear
Copy link

linear bot commented Aug 29, 2023

PRO-1892 Generate GRPC endpoints for valuations-api

as dimo eng, I still want old devices-api valuations and offers endpoints to work even though all the data is in a new api.

Acceptance Criteria

  • Create new GRPC endpoints that serve up /valuations and /offers data given a userDeviceID. All the logic already exists in the controller, but will likely need to be refactored so it can be re-used from grpc side.
  • update devices-api /valuations and /offers endpoints to call new grpc endpoints respectively from valuations-api
  • remove any existing logic that is not used anymore with this change from devices-api

@Asfiroth Asfiroth merged commit 29a6a8c into main Aug 30, 2023
2 checks passed
@Asfiroth Asfiroth deleted the PRO-1892 branch August 30, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesReate JamesReate JamesReate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Asfiroth @JamesReate