PRO-1800 - set powertrain from device definition #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-1800 Devices api user_device powertrain set from device definition
We currently set the user_device.metadata.powertrain in devices-api when it gets registered by calling NHTSA plus some logic. We want to remove this and have it be handled in the device definition side. Just set the powertrain based on what the device definitions comes back with for the powertrain. Only tricky thing is that since the user device usually gets created after a vin decode call, we want to make sure the powertrain is coming set from that decode grpc call. If there is not Powertrain in Device Definitions, log a warning. |
JamesReate
approved these changes
Aug 16, 2023
JamesReate
reviewed
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Impacted Routes
Caveats