Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-1707 - Add powertraintype to grpc endpoint #169

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

rhvivancoeffio
Copy link
Contributor

Proposed Changes

Impacted Routes

Caveats

@linear
Copy link

linear bot commented Jul 26, 2023

PRO-1707 Load PowertrainType from UserDevice into reports for Vehicle Data

  1. add array column to available properties with the powertrain that applies to, null or empty for all
  2. grpc GetUserDevice, need to add the Metadata properties to be exposed so we can get the powertrain type
  3. when querying GetSignals, the denominator (ie count of all) should be based only on the powertrains impacted, this will require persisting something in signal_events_tracking so that we can know what to exclude at query time.

Copy link
Member

@JamesReate JamesReate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in here it occurred to me let's also add the Protocol:
CANProtocol *string json:"canProtocol,omitempty"`` from the UserDeviceMetadata

Then also just update your local protoc to latest and regen protos

@rhvivancoeffio rhvivancoeffio merged commit 1e5bab4 into main Jul 26, 2023
1 of 2 checks passed
@rhvivancoeffio rhvivancoeffio deleted the devices-api-grpc-powertraintype branch July 26, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants