Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-1653 add manuf token id col, change pkey, update fkeys #163

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

JamesReate
Copy link
Member

Proposed Changes

  • add device_manufacturer_token_id
  • delete bad data
  • update pkey
  • update and rebuild fkeys

Impacted Routes

Caveats

@linear
Copy link

linear bot commented Jul 19, 2023

PRO-1653 add device_make_id to aftermarket_devices & pkey change

device_make_id should point to the device_definitions makes.

Update Admin to show the resolved value.

  • Make the ethereum_address the primary key.
  • the serial should be unique

@JamesReate JamesReate added the wip label Jul 19, 2023
@JamesReate
Copy link
Member Author

@elffjs the following test is failing but I can't tell why, the TokenID is nil, which results in a conflict being returned - is this test setup?

@JamesReate JamesReate requested a review from elffjs July 20, 2023 01:38
@elffjs
Copy link
Member

elffjs commented Jul 20, 2023

I don't know. I will look tomorrow.

I don't see how the token id could be nil. We set it.

@JamesReate
Copy link
Member Author

ah it seems to be b/c of the pkey change the boiler Update isn't updating

@JamesReate JamesReate merged commit 8c7e135 into main Jul 20, 2023
2 checks passed
@JamesReate JamesReate deleted the pro-1653_aftermarket-pkey-change-make branch July 20, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants