Remove nav for accessibility purposes #7232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an accessibility audit this page was found to have issues due to have two nav elements in close proximity. To fix this i have taken the applicable code from the sort component and hard coded it onto the page with the nav that wraps it removed. I did not remove the nav from the actual component because this component is used in multiple other places, none of which (as far as I know) are causing accessibility issues.
|
Review app deployed to https://teaching-vacancies-review-pr-7232.test.teacherservices.cloud on AKS |
scruti
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/WfHBvyAy/1375-accessibility-hiring-staff-active-jobs-page-duplicate-navigation-elements
Changes in this PR:
During an accessibility audit this page was found to have issues due to have two nav elements in close proximity. To fix this i have taken the code from the sort component and hard coded it onto the page with the nav that wraps it removed. I did not remove the nav from the actual component because this component is used in multiple other places, none of which (as far as I know) are causing accessibility issues.
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?