Faith school catholic flow #7222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starswan
force-pushed
the
faith-school-catholic-flow
branch
from
ac56cc3
to
9f3e5a7
Compare
starswan
changed the base branch from
faith-schools-flow
to
faith-school-choose-form
ddippolito
reviewed
Nov 4, 2024
| @@ -332,59 +332,6 @@ Metrics/BlockLength: | |||
| Metrics/ClassLength: | |||
| Max: 179 | |||
|
|
|||
| # Offense count: 93 | |||
| RSpec/AnyInstance: | |||
There was a problem hiding this comment.
We had so many. Good trim
ddippolito
reviewed
Nov 4, 2024
| = f.govuk_radio_buttons_fieldset :following_religion do | ||
| = f.govuk_radio_button :following_religion, true, link_errors: true, label: { text: t("helpers.label.jobseekers_job_application_following_religion_form.following_religion_options.yes") } | ||
| = f.govuk_radio_button :following_religion, false, label: { text: t("helpers.label.jobseekers_job_application_following_religion_form.following_religion_options.no") } | ||
| / = f.govuk_radio_button :following_religion, :yes, link_errors: true |
There was a problem hiding this comment.
Do we need to remove these?
ddippolito
approved these changes
Nov 4, 2024
starswan
force-pushed
the
faith-school-catholic-flow
branch
from
d2d2320
to
d8275bd
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-7222.test.teacherservices.cloud on AKS |
Base automatically changed from
faith-school-choose-form
to
faith-schools-flow
November 4, 2024 12:07
starswan
force-pushed
the
faith-schools-flow
branch
from
c2c5f72
to
b05a974
Compare
starswan
force-pushed
the
faith-school-catholic-flow
branch
from
d8275bd
to
ef2f3e2
Compare
starswan
force-pushed
the
faith-schools-flow
branch
from
b05a974
to
b2c49e7
Compare
starswan
force-pushed
the
faith-school-catholic-flow
branch
from
ef2f3e2
to
9093a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/WcdDCjEc/1325-faith-schools-add-religious-information-section-ces-flow-top-radio
Changes in this PR:
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?