Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Do not show deleted projects in the "Added by" page #1934

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

lozette
Copy link
Collaborator

@lozette lozette commented Oct 2, 2024

A user reported that they were seeing a deleted project in their "Added by" page. We were not explicitly excluding deleted projects from the "Added by" page or scope.

@lozette lozette force-pushed the feature/182743-remove-deleted-from-added-by branch from e0bff8b to 32db203 Compare October 2, 2024 16:11
Copy link
Collaborator

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but it might be worth switching these to:

Project.added_by.active

as that would exclude deleted, completed, dao_revoked and inactive more succinctly?

A user reported that they were seeing a deleted project in their
"Added by" page. We were not explicity excluding deleted projects
from the "Added by" page or scope.
@lozette lozette force-pushed the feature/182743-remove-deleted-from-added-by branch from 32db203 to 7dc4b5a Compare October 3, 2024 08:02
@lozette lozette enabled auto-merge October 3, 2024 08:02
@lozette lozette merged commit d19223d into main Oct 3, 2024
8 checks passed
@lozette lozette deleted the feature/182743-remove-deleted-from-added-by branch October 3, 2024 08:09
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants