(Fix) A contact must be assigned to a project before it is added as chair of governors #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hair of governors While writing code elsewhere we uncovered a small anomaly in this test - the contact which is created to be the Chair of Governors contact for a project must actually belong to that project before it is assigned. In not linking the contact to the project, the test is actually reassigning the contact from one project to another, as well as updating its attributes. This anomaly was showing up as a bug in other branches (specifically when working on soft deleting projects).
|
mec
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing code elsewhere we uncovered a small anomaly in this test - the contact which is created to be the Chair of Governors contact for a project must actually belong to that project before it is assigned. In not linking the contact to the project, the test is actually reassigning the contact from one project to another, as well as updating its attributes.
This anomaly was showing up as a bug in other branches (specifically when working on soft deleting projects).