Introduce a concept of "state" to projects #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lozette
force-pushed
the
feature/161543-projects-have-a-state
branch
3 times, most recently
from
5fc9b20
to
d5a21da
Compare
2 tasks
We want to be able to mark projects as "deleted", but not actually delete the record from the database. We intend to add a deleted state to projects. Ahead of this, we have decided to add a `state` to projects, and enumerate it for the various different states a project can be in. For now, this is "active" and "completed" Add an enumerator to projects - 0 for active (default) and 1 for completed. As the state is an enumerator, we get the scope Project.completed for free now. Due to Rails magic, we also get Project.not_completed - anything not in the completed state. For now, this is "active", but in future if we add more states we will need to make "not complete" more specific (ie if we add a deleted state, then deleted will also fall under "not completed") As the original Project.completed scope had an order (ordering by completed_at date) we have had to split this ordering out and add it as a new scope. We have added the new state to the project factories, and updated the relevant tests. Unfortunately this was the smallest single commit we could make for this change.
Now that we have the project state as an enumerable, we get Project.active scope for free and we can use it to replace any instances of Project.not_completed
lozette
force-pushed
the
feature/161543-projects-have-a-state
branch
from
d5a21da
to
f8c0af5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to mark projects as "deleted", but not actually delete the record from the database. We intend to add a deleted state to projects .
Ahead of this, we have decided to add a
stateto projects, and enumerate it for the various different states a project can be in. For now, this is "active" and "completed"Add an enumerator to projects - 0 for active (default) and 1 for completed.
As the state is an enumerator, we get the scope Project.completed for free now. Due to Rails magic, we also get Project.not_completed - anything not in the completed state. In the first commit, we keep Project.not_completed as is; in the second, we replace Project.not_completed with the more semantic Project.active.
As the original Project.completed scope had an order (ordering by completed_at date) we have had to split this ordering out and add it as a new scope.
We have added the new state to the project factories, and updated the relevant tests.
Unfortunately this was the smallest single commit we could make for this change.
(No user-facing changes in this commit)