(Chore) Refactors and redundant code removal #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lozette
force-pushed
the
chore/refactors
branch
3 times, most recently
from
2bd0dc3
to
ec254c8
Compare
Speed things up slightly by only calling ProjectsForExportService once
This was a task designed to be run once to update historic projects which did not have a mandatory piece of data (the date the Grant Certificate was received) As we do not need this importer now, we can delete it to speed up the test suite
This task is not used in the task list and all its tests are skipped. Remove it for now - we can re-add it if it's needed later.
…possible Slim down these specs by removing repeated unnecessary calls to mocks, and using `build` instead of `create` for stubs where appropriate.
These specs currently iterate over 20-odd pages to check for the absence of a button. We only need to check one page, as all the task pages use the same Policy to restrict edit access. This speeds up two of our slowest specs.
We were using the same method `not_applicable_for_a_transfer` method to check the correct value was being output for both Academy order type and Sponsored grant type for transfers. However, the method `not_applicable_for_a_transfer` only checked the Academy order type, so it was concealing a potential bug in the Sponsored grant type presenter. Remove this method and explicitly check for the correct values.
lozette
force-pushed
the
chore/refactors
branch
from
ec254c8
to
70226e9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some refactoring and removal of unneeded code, plus a small bugfix.
createwithbuildwhere possible to speed things up