Refactor Service Support permissions #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mec
force-pushed
the
chore/refactor-service-support-permissions
branch
from
340ead9
to
0c00036
Compare
I was tasked with allowing service support users to edit projects and got confused between the specs and policy. Having `@user.is_service_support?` inside the `project_assigned_to_user?` was too much for me, so I have moved it out into the main method were it reads clearly which users can update a project.
We want service support users to be able to change any of the assignments.
mec
force-pushed
the
chore/refactor-service-support-permissions
branch
from
0c00036
to
c0728b7
Compare
lozette
approved these changes
Mar 21, 2024
Whilst earlier implementation allowed them to do this, we refactored that so this work allows them to once again change the conversion or transfer date on a project.
mec
force-pushed
the
chore/refactor-service-support-permissions
branch
from
c0728b7
to
39b0d32
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to allow Service Support to:
It turned out most of this was already possible because we include Service
Support users in the
project_assigned_to_user?policy method.I found this really hard to follow, so I've taken it out and hopefully left
things a little simpler to follow.
This work also allows Service Support to change the assignment, something that
was not previously possible.