Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add logger proto #135

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat : add logger proto #135

wants to merge 2 commits into from

Conversation

AgwaB
Copy link
Contributor

@AgwaB AgwaB commented Jun 16, 2019 •
edited
Loading

Related Issue

resolve: #129

Description

  • use iLogger : based logrus
  • remove bba's tracer

log level
Info : component start or done
Debug : method execution
Error : error

basic format

"comp" : "rbc",
"owner" : "address",
"proposer" : "address"
"comp" : "bba",
"owner" : "address",
"round" : 0

disadvantage
The format is printed at the end of the log like below
image

If you want to see debug log at test, add iLogger.SetToDebug(). it's singleton.

Checklist

Thank you for your contribution.
Before submitting this PR, please make sure:

  • Applying goimports
  • Test case
  • End of Work

@AgwaB AgwaB requested a review from zeroFruit June 16, 2019 06:33
@AgwaB AgwaB force-pushed the feat/log branch 3 times, most recently from f288a56 to 54e6c58 Compare June 16, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroFruit zeroFruit Awaiting requested review from zeroFruit

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[log] logging system
1 participant
@AgwaB