Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log] logging system #129

Open
AgwaB opened this issue Jun 11, 2019 · 1 comment · May be fixed by #135
Open

[log] logging system #129

AgwaB opened this issue Jun 11, 2019 · 1 comment · May be fixed by #135
Assignees
Labels
help wanted Extra attention is needed important

Comments

@AgwaB
Copy link
Contributor

AgwaB commented Jun 11, 2019

This is no longer future work. In an asynchronous environment, logging system is required!!! we can't expect many scenario and debug easily.

For example, go-ethereum has 6-level-log option
Logging verbosity: 0=silent, 1=error, 2=warn, 3=info, 4=core, 5=debug, 6=detail (default: 3)

And parity can only log special actions
sync=debug,rpc=trace

Now we use iLogger which based on logrus. and iLogger has 6-level for log
Info, Warn, Debug, Error, Fatal, Panic

And i think we need to log each component(Especially ACS, RBC, BBA) like parity can only log rpc or sync!

Reference
https://www.datadoghq.com/blog/go-logging/#track-golang-logs-across-microservices
https://github.com/DE-labtory/iLogger
https://github.com/sirupsen/logrus
https://github.com/ethereum/go-ethereum/tree/master/log

#128
-> it maybe used only test

@AgwaB AgwaB added help wanted Extra attention is needed important labels Jun 11, 2019
@AgwaB
Copy link
Contributor Author

AgwaB commented Jun 16, 2019

@AgwaB

@AgwaB AgwaB self-assigned this Jun 16, 2019
@AgwaB AgwaB linked a pull request Jun 16, 2019 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant