Skip to content

Commit

Permalink
Merge pull request #1133 from DDMAL/neume-parent-check
Browse files Browse the repository at this point in the history
Temporarily modify neume grouping for user accecptance test
  • Loading branch information
yinanazhou authored Nov 8, 2023
2 parents 0e7090e + 49e3a91 commit c708706
Show file tree
Hide file tree
Showing 4 changed files with 82 additions and 82 deletions.
54 changes: 27 additions & 27 deletions assets/js/verovio-toolkit.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/SquareEdit/Grouping.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export function isGroupable(selectionType: string, elements: Array<SVGGraphicsEl
switch(selectionType) {
case 'selByNeume':
// if neumes are in same syllable, don't display grouping option
if (SelectTools.sharedLogicalParent(selectionType, elements)) return false;
if (!SelectTools.sharedLogicalParent(selectionType, elements)) return false;

default:
// check if all selected elements are adjacent to each other
Expand Down
54 changes: 27 additions & 27 deletions verovio-util/verovio-dev/index.js

Large diffs are not rendered by default.

54 changes: 27 additions & 27 deletions verovio-util/verovio.js

Large diffs are not rendered by default.

0 comments on commit c708706

Please sign in to comment.