Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracking.rst in docs/concepts/ #405

Merged
merged 4 commits into from
Oct 19, 2024
Merged

Conversation

danieltayal07
Copy link
Contributor

@danieltayal07 danieltayal07 commented Oct 19, 2024

[Short description explaining the high-level reason for the pull request]

Changes

Changed the outdated code to the code provided in the issue from docs/concepts/tracking.rst

How I tested this

i wasn't able to test it, i don't know how to please tell me how to if possible!

Notes

Checklist

  • [ ✅] PR has an informative and human-readable title (this will be pulled into the release notes)
  • [✅ ] Changes are limited to a single goal (no scope creep)
  • [✅ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • [✅ ] Any change in functionality is tested
  • [✅ ] New functions are documented (with a description, list of inputs, and expected output)
  • [✅ ] Placeholder code is flagged / future TODOs are captured in comments
  • [✅ ] Project documentation has been updated if adding/changing functionality.

Important

Update tracking.rst to use LocalTrackingClient and correct ApplicationBuilder initialization.

  • Documentation Update:
    • In tracking.rst, update code example to use LocalTrackingClient instead of client.
    • Modify ApplicationBuilder initialization to include .with_graph(base_graph), .initialize_from(), and .with_tracker(tracker) methods with appropriate parameters.

This description was created by Ellipsis for 7eed117. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 7eed117 in 13 seconds

More details
  • Looked at 45 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_Orq0v7ls0g77owwf


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

docs/concepts/tracking.rst Outdated Show resolved Hide resolved
@skrawcz skrawcz linked an issue Oct 19, 2024 that may be closed by this pull request
@skrawcz skrawcz merged commit 5fae679 into DAGWorks-Inc:main Oct 19, 2024
10 of 11 checks passed
@danieltayal07
Copy link
Contributor Author

Thank you So much! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecated code in docs
2 participants