Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo in tool-calling example #380

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

elijahbenizzy
Copy link
Contributor

@elijahbenizzy elijahbenizzy commented Sep 30, 2024

Important

Fixes string concatenation typo in _order_coffee_tool function in application.py.

  • Bug Fix:
    • Fixes string concatenation typo in _order_coffee_tool function in application.py. Uses f-string for any_modifications instead of string concatenation.

This description was created by Ellipsis for f7206f5. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f7206f5 in 5 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. examples/tool-calling/application.py:51
  • Draft comment:
    Fixes a string formatting issue by adding the missing 'f' for the f-string, ensuring 'any_modifications' is evaluated correctly.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR is a simple fix for a string formatting issue. The original code was missing an 'f' for the f-string, which would cause the variable 'any_modifications' to not be evaluated correctly. The fix correctly adds the 'f' to the string, ensuring proper evaluation.

Workflow ID: wflow_2tnwiDkmoraDojpe


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@elijahbenizzy elijahbenizzy merged commit 56be42c into main Sep 30, 2024
11 checks passed
@elijahbenizzy elijahbenizzy deleted the minor-example-typo branch September 30, 2024 21:00
Copy link

github-actions bot commented Sep 30, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/380

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/380/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant