Add pre-propose-approval support for multiple choice proposals, and freeze approver #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #883 +/- ##
===============================================
- Coverage 96.67% 96.65% -0.03%
===============================================
Files 241 245 +4
Lines 65993 67224 +1231
===============================================
+ Hits 63802 64974 +1172
- Misses 2191 2250 +59 ☔ View full report in Codecov by Sentry. |
NoahSaso
changed the title
NoahSaso
changed the title
bekauz
approved these changes
Oct 8, 2024
|
|
||
| let completed_proposals = | ||
| dao_pre_propose_approval_single_v241::state::COMPLETED_PROPOSALS | ||
| .range(deps.storage, None, None, Order::Ascending) |
There was a problem hiding this comment.
wonder from how many props this could fail. maybe worth to do some test runs?
There was a problem hiding this comment.
yeah.. what's the easiest way to test this?
There was a problem hiding this comment.
both test-tube and interchaintest provide this. probably interchaintest would be easiest to test across multiple chains, but require a bit more upfront setup than test-tube
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does two things:
it creates a dao-pre-propose-approval-multiple contract so that multiple choice proposal modules can have approvers, just like single choice proposal modules. it also ensures the approver contract works for both approval-single and approval-multiple
it freezes the
approverin the proposal so that a previously created pending proposal does not change approvers if the approver gets updated while it's still pending. this maintains consistency with other DAO logic to keep things intuitive, where the members who can vote on a proposal are frozen upon proposal creation.