-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict JSON Schema validation #1128
base: master
Are you sure you want to change the base?
Conversation
2eab6bd
to
16d5c71
Compare
Signed-off-by: Maxime Robert <[email protected]>
16d5c71
to
f84aa82
Compare
Hi @marob I have started addressing the related concerns as part of #1107 I have a branch going with the changes and it is close to being completed. But still have a TODO in one code file. Do you want to take over and run with these changes I started as part of this pull request to address all the related issues for this one? https://github.com/CycloneDX/cdxgen/compare/master...timmyteo:cdxgen:feature/issue-1107?expand=1 |
Hi @timmyteo. I can try to finish but I'm not sure I'll have time. |
Ok no problem @marob. If you run out of time then let me know. |
@timmyteo Here is what I came up with from your branch: master...marob:cdxgen:feature/issue-1107 |
Changes look great @marob! I like the improvements you made to the original. Very clean. Thanks for your work here. |
I've created this MR that should replace this one. |
No description provided.