Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-mode #90

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Remove python-mode #90

merged 2 commits into from
Sep 22, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Sep 20, 2023

Need to remove packages in apt.txt like python-mode which is not available in Ubuntu 22.04 Jammy Jellyfish, because the default docker base image used by repo2docker has changed from docker.io/library/buildpack-deps:bionic (18.04) to docker.io/library/buildpack-deps:jammy (22.04), see jupyterhub/repo2docker#1304.

Xref #89 (comment).

Not available in Ubuntu Jammy Jellyfish 22.04 repos used by repo2docker. See https://packages.ubuntu.com/focal/python-mode.
@weiji14 weiji14 self-assigned this Sep 20, 2023
@github-actions
Copy link

Binder 👈 Test this PR on Binder

@weiji14 weiji14 mentioned this pull request Sep 20, 2023
@weiji14
Copy link
Member Author

weiji14 commented Sep 20, 2023

/condalock

@@ -14,7 +14,7 @@ jobs:
permissions:
contents: write # for Git to git push
runs-on: ubuntu-latest
timeout-minutes: 15
timeout-minutes: 30
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda-lock keeps timing out, so have increased this from 15 to 30min.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about running conda-lock with the mamba solver (--mamba)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we're running it with mamba already

conda-lock lock --mamba --kind explicit --file environment.yml --platform linux-64

So not sure why the solver is still taking that long. It only takes 35s on my laptop 😅

Copy link
Member Author

@weiji14 weiji14 Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we pass the --mamba flag, but I'm not sure if mamba is actually installed 😳. Should take a look.

Edit: Opened PR at #91

@weiji14 weiji14 marked this pull request as ready for review September 20, 2023 22:51
@MattF-NSIDC
Copy link

the default docker base image used by repo2docker has changed from docker.io/library/buildpack-deps:bionic (18.04) to docker.io/library/buildpack-deps:jammy (22.04), see jupyterhub/repo2docker#1304.

Ooh, exciting! I was wondering when the default image would be bumped :)

@weiji14 weiji14 merged commit 796e7bc into main Sep 22, 2023
1 check passed
@weiji14 weiji14 deleted the rm-python-mode branch September 22, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants