-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python-mode #90
Conversation
Not available in Ubuntu Jammy Jellyfish 22.04 repos used by repo2docker. See https://packages.ubuntu.com/focal/python-mode.
/condalock |
@@ -14,7 +14,7 @@ jobs: | |||
permissions: | |||
contents: write # for Git to git push | |||
runs-on: ubuntu-latest | |||
timeout-minutes: 15 | |||
timeout-minutes: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda-lock
keeps timing out, so have increased this from 15 to 30min.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about running conda-lock
with the mamba solver (--mamba
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we're running it with mamba already
conda-lock lock --mamba --kind explicit --file environment.yml --platform linux-64 |
So not sure why the solver is still taking that long. It only takes 35s on my laptop 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we pass the --mamba
flag, but I'm not sure if mamba
is actually installed 😳. Should take a look.
Edit: Opened PR at #91
Ooh, exciting! I was wondering when the default image would be bumped :) |
Need to remove packages in apt.txt like
python-mode
which is not available in Ubuntu 22.04 Jammy Jellyfish, because the default docker base image used by repo2docker has changed fromdocker.io/library/buildpack-deps:bionic
(18.04) todocker.io/library/buildpack-deps:jammy
(22.04), see jupyterhub/repo2docker#1304.Xref #89 (comment).