fix: add missing HTTP transport defaults when bypassing Artifactory #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we revert #549 and bump https://github.com/containers/image to v5.31.1? It might make more sense. |
|
Oh, I wasn't aware the issue had been fixed. Yeah, that makes more sense. |
|
Neither was I until today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A workaround was previously added to bypass an open issue in Artifactory, but that workaround did not use the default HTTP transport provided by the Go library. As a result, some capabilities were missing (e.g. proxy support). This change introduces a transport based on the library default.