Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use generic column types in resize-handle and data-sorting plugins (#247) #248

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

johanrd
Copy link
Contributor

@johanrd johanrd commented Feb 21, 2024

Proposed fix for #247 for Resize-handle and data-sorting

Copy link

changeset-bot bot commented Feb 21, 2024

⚠️ No Changeset found

Latest commit: e26a127

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@johanrd johanrd changed the title Use generic column types in plugins Use generic column types in resize-handle and data-sorting plugins Feb 21, 2024
@johanrd johanrd changed the title Use generic column types in resize-handle and data-sorting plugins fix: Use generic column types in resize-handle and data-sorting plugins (#247) Feb 21, 2024
@johanrd
Copy link
Contributor Author

johanrd commented Feb 21, 2024

I had to wait with the sort, sortDescending and sortAscending helpers:

export const sort = (column: Column) => meta.forTable(column.table, Sorting).handleSort(column);
/**
* Toggle a column between descending and not unsorted states
*/
export const sortDescending = (column: Column) =>
meta.forTable(column.table, Sorting).toggleDescending(column);
/**
* Toggle a column between ascending and not unsorted states
*/
export const sortAscending = (column: Column) =>
meta.forTable(column.table, Sorting).toggleAscending(column);

For some reason, I didn't get the generics to work for the meta.forTable(column.table, Sorting).handleSort(column) (reverted here: 10a9e26, see failing test: https://github.com/CrowdStrike/ember-headless-table/actions/runs/7989097110/job/21815050164?pr=248#step:4:67

@NullVoxPopuli perhaps you know how to pass on the generic Column through meta.forTable? thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant