Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toggle for become on windows #561

Merged

Conversation

chipselden
Copy link
Contributor

This PR adds a new variable falcon_windows_become to the install, configure, and uninstall roles so that privilege escalation may be disabled if necessary.

Depending on how a Windows machine is configured and which user is used, becoming another user may be unnecessary.

@carlosmmatos carlosmmatos self-assigned this Sep 5, 2024
@carlosmmatos carlosmmatos added minor_changes New features, like plugin or module options ok-to-test Run tests labels Sep 5, 2024
@carlosmmatos
Copy link
Contributor

@chipselden appreciate the PR. Going to run it through the CI but looking at it really quickly it makes sense.

@carlosmmatos carlosmmatos added this to the 4.6.0 milestone Sep 5, 2024
Copy link
Contributor

@carlosmmatos carlosmmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlosmmatos carlosmmatos merged commit 581997a into CrowdStrike:main Sep 5, 2024
2 checks passed
@chipselden chipselden deleted the feat/windows-become-toggle branch September 5, 2024 22:16
@chipselden chipselden restored the feat/windows-become-toggle branch September 5, 2024 22:18
@chipselden
Copy link
Contributor Author

Thanks so much for the quick work on this @carlosmmatos! Do you have a projected timeline for releasing a new version?

@carlosmmatos
Copy link
Contributor

Soon.. hopefully by tomorrow EOD. Just going over some stuff and trying to handle low hanging fruit.

@carlosmmatos
Copy link
Contributor

@chipselden 4.6.0 has been released!

In case you don't have notifications for new releases set up - you can do this by:

Selecting the watch/unwatch dropdown:
CleanShot 2024-09-06 at 10 28 56@2x

Then select -> custom
CleanShot 2024-09-06 at 10 31 39@2x

And finally you can add releases
CleanShot 2024-09-06 at 10 32 21@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor_changes New features, like plugin or module options ok-to-test Run tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants