Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bg color to highlight diagnostics? #10

Open
CptPotato opened this issue Jan 30, 2023 · 2 comments
Open

Use bg color to highlight diagnostics? #10

CptPotato opened this issue Jan 30, 2023 · 2 comments

Comments

@CptPotato
Copy link
Owner

I've experimented with using git diff colors to highlight LSP diagnostics in the source code, and I quite like the result:

image

@epbuennig if you don't mind, since you were somewhat involved (#7), what do you think? Does this help visibility and "look good" without being too distracting or do you prefer the background-less version?

@epbuennig
Copy link
Contributor

I think the background certainly helps in the cases where the underlines have the same shape. I personally don't like the style of the text having a light background on it, but that would certainly push me personally to resolve the issues quicker.

Ill have to check at home if it increases visibility on larger code snippets.

I think a style change that helps visibility is more important than over all style preference for me.

@CptPotato
Copy link
Owner Author

Thanks for sharing your opinion.

I think I'll leave the themes in this repo unchanged for now, unless there are people who would like to see this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants